You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/15 03:00:49 UTC
[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9333
Change subject: [CMakeLists] un-break build with gcc 4.9.2
......................................................................
[CMakeLists] un-break build with gcc 4.9.2
This is a quick fix to un-break build of Kudu as a part of Impala's
build with gcc 4.9.2.
For some reason, the compiler is happy with the -fsized-deallocation
option while compiling the small test, but then the compilation fails
with errors like below:
g++: error: unrecognized command line option ‘-fsized-deallocation’
g++: error: unrecognized command line option ‘-fno-sized-deallocation’
Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
---
M CMakeLists.txt
1 file changed, 29 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9333/1
--
To view, visit http://gerrit.cloudera.org:8080/9333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Gerrit-Change-Number: 9333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 )
Change subject: [CMakeLists] un-break build with gcc 4.9.2
......................................................................
Patch Set 1:
(1 comment)
This change makes sense. I am testing on an SLES instance to see if I can understand why the check didn't work quickly too.
http://gerrit.cloudera.org:8080/#/c/9333/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9333/1/CMakeLists.txt@1102
PS1, Line 1102: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsized-deallocation")
Can this and line 1111 be moved into if(COMPILER_SUPPORTS_SIZED_DEALLOCATION) below?
--
To view, visit http://gerrit.cloudera.org:8080/9333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Gerrit-Change-Number: 9333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Feb 2018 03:47:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 )
Change subject: [CMakeLists] un-break build with gcc 4.9.2
......................................................................
Patch Set 1:
I ran a test build on SLES12 with gcc 4.8.5 (Impala has 4.9.2) and everything worked fine. I am still curios why the check doesn't work in that environment.
--
To view, visit http://gerrit.cloudera.org:8080/9333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Gerrit-Change-Number: 9333
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Feb 2018 05:33:09 +0000
Gerrit-HasComments: No
[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 )
Change subject: [CMakeLists] un-break build with gcc 4.9.2
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Gerrit-Change-Number: 9333
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Feb 2018 05:33:40 +0000
Gerrit-HasComments: No
[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9333 )
Change subject: [CMakeLists] un-break build with gcc 4.9.2
......................................................................
[CMakeLists] un-break build with gcc 4.9.2
This is a quick fix to un-break build of Kudu as a part of Impala's
build with gcc 4.9.2.
For some reason, the compiler is happy with the -fsized-deallocation
option while compiling the small test, but then the compilation fails
with errors like below:
g++: error: unrecognized command line option ‘-fsized-deallocation’
g++: error: unrecognized command line option ‘-fno-sized-deallocation’
Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Reviewed-on: http://gerrit.cloudera.org:8080/9333
Reviewed-by: Grant Henke <gr...@gmail.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
1 file changed, 27 insertions(+), 11 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Gerrit-Change-Number: 9333
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9333
to look at the new patch set (#2).
Change subject: [CMakeLists] un-break build with gcc 4.9.2
......................................................................
[CMakeLists] un-break build with gcc 4.9.2
This is a quick fix to un-break build of Kudu as a part of Impala's
build with gcc 4.9.2.
For some reason, the compiler is happy with the -fsized-deallocation
option while compiling the small test, but then the compilation fails
with errors like below:
g++: error: unrecognized command line option ‘-fsized-deallocation’
g++: error: unrecognized command line option ‘-fno-sized-deallocation’
Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
---
M CMakeLists.txt
1 file changed, 27 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/9333/2
--
To view, visit http://gerrit.cloudera.org:8080/9333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Gerrit-Change-Number: 9333
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [CMakeLists] un-break build with gcc 4.9.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9333 )
Change subject: [CMakeLists] un-break build with gcc 4.9.2
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9333/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9333/1/CMakeLists.txt@1102
PS1, Line 1102: endif()
> Can this and line 1111 be moved into if(COMPILER_SUPPORTS_SIZED_DEALLOCATI
Done
--
To view, visit http://gerrit.cloudera.org:8080/9333
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie02ae6229023101cca9f3a39292a648d20349a88
Gerrit-Change-Number: 9333
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 15 Feb 2018 05:24:38 +0000
Gerrit-HasComments: Yes