You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/05/02 23:07:30 UTC
Re: Review Request 58720: CLI: Extended the unit test infrastructure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58720/#review173673
-----------------------------------------------------------
src/cli_new/lib/cli/tests/base.py
Lines 133 (patched)
<https://reviews.apache.org/r/58720/#comment246698>
We should use the `.format` syntax here. Also, we should use `os.path.join`.
- Kevin Klues
On April 25, 2017, 10:18 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58720/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 10:18 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7283
> https://issues.apache.org/jira/browse/MESOS-7283
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This infrastructure includes the ability to bring up a test cluster to
> run the CLI against. Future unit tests will use this infrastructure to
> test their commands against a running mesos cluster. The tests require
> some binaries created when building Mesos.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/tests/__init__.py PRE-CREATION
> src/cli_new/lib/cli/tests/base.py PRE-CREATION
> src/cli_new/lib/cli/tests/tests.py PRE-CREATION
> src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83
> src/cli_new/tests/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6
>
>
> Diff: https://reviews.apache.org/r/58720/diff/1/
>
>
> Testing
> -------
>
> PEP8 and Pylint used to make sure that the code style is correct. Manuel test:
>
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
>
> (mesos-cli) $ mesos-cli-tests
>
>
> Thanks,
>
> Armand Grillet
>
>