You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by akashrn5 <gi...@git.apache.org> on 2018/02/08 17:59:52 UTC

[GitHub] carbondata pull request #1957: [CARBONDATA-2150] Unwanted updatetable status...

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1957

    [CARBONDATA-2150] Unwanted updatetable status files are being generated for the delete operation where no records are deleted

    **Problem:** Unwanted updatetable status files are being generated for the delete operation where no records are deleted
    
    **Analysis:**when the filter value for delete operation is less than the maximum value in that column, then getsplits() will return the block and hence in delete logic, it was creating update table status file even though delete operation was not done.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [x] Any interfaces changed?
     NA
     - [x] Any backward compatibility impacted?
     NA
     - [x] Document update required?
    NA
     - [x] Testing done
    test cases are added
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata del

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1957
    
----
commit af1ae4cdbcec7f590a5eff5dca3e88899cda6916
Author: akashrn5 <ak...@...>
Date:   2018-02-08T17:40:43Z

    unwanted updatetablestatus files are being created for delete operation where no records are selected

----


---

[GitHub] carbondata pull request #1957: [CARBONDATA-2150] Unwanted updatetable status...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1957


---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    retest this please


---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2410/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3487/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2362/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2401/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2405/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    LGTM


---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3478/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    retest this please


---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3644/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3642/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    retest sdv please


---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3600/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3450/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3649/



---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by akashrn5 <gi...@git.apache.org>.
Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    retest sdv please


---

[GitHub] carbondata issue #1957: [CARBONDATA-2150] Unwanted updatetable status files ...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1957
  
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3482/



---