You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "0528Mike (via GitHub)" <gi...@apache.org> on 2023/09/07 03:22:02 UTC
[GitHub] [nuttx-apps] 0528Mike opened a new pull request, #2039: codecs: add md5_file API
0528Mike opened a new pull request, #2039:
URL: https://github.com/apache/nuttx-apps/pull/2039
## Summary
Add the API for 'md5_file' to directly obtain the digest value by passing in the file path
## Impact
None
## Testing
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #2039: codecs: add md5_file API
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2039:
URL: https://github.com/apache/nuttx-apps/pull/2039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #2039: codecs: add md5_file API
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #2039:
URL: https://github.com/apache/nuttx-apps/pull/2039#discussion_r1319160054
##########
netutils/codecs/md5.c:
##########
@@ -406,4 +411,59 @@ char *md5_hash(const uint8_t * addr, const size_t len)
return hash;
}
+/****************************************************************************
+ * Name: md5_file
+ *
+ * Description:
+ * MD5 hash for a file
+ *
+ * Input Parameters:
+ * path: File Path
+ * mac : Buffer for the hash
+ *
+ ****************************************************************************/
+
+int md5_file(const char *path, uint8_t *mac)
Review Comment:
Yes. Sure. It is more like a "note" comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #2039: codecs: add md5_file API
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #2039:
URL: https://github.com/apache/nuttx-apps/pull/2039#discussion_r1318262308
##########
netutils/codecs/md5.c:
##########
@@ -406,4 +411,59 @@ char *md5_hash(const uint8_t * addr, const size_t len)
return hash;
}
+/****************************************************************************
+ * Name: md5_file
+ *
+ * Description:
+ * MD5 hash for a file
+ *
+ * Input Parameters:
+ * path: File Path
+ * mac : Buffer for the hash
+ *
+ ****************************************************************************/
+
+int md5_file(const char *path, uint8_t *mac)
Review Comment:
General comment: Need to add `FAR` to pointers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #2039: codecs: add md5_file API
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2039:
URL: https://github.com/apache/nuttx-apps/pull/2039#discussion_r1318667650
##########
netutils/codecs/md5.c:
##########
@@ -406,4 +411,59 @@ char *md5_hash(const uint8_t * addr, const size_t len)
return hash;
}
+/****************************************************************************
+ * Name: md5_file
+ *
+ * Description:
+ * MD5 hash for a file
+ *
+ * Input Parameters:
+ * path: File Path
+ * mac : Buffer for the hash
+ *
+ ****************************************************************************/
+
+int md5_file(const char *path, uint8_t *mac)
Review Comment:
@pkarashchenko The whole code base doesn't add FAR, so it's better to put into the new patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org