[GitHub] [superset] villebro commented on a change in pull request #17205: fix: reenabling terser plugin for webpack

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #17205:
URL: https://github.com/apache/superset/pull/17205#discussion_r735293139



##########
File path: superset-frontend/webpack.config.js
##########
@@ -274,7 +274,7 @@ const config = {
       },
     },
     usedExports: 'global',
-    minimizer: [new CssMinimizerPlugin()],
+    minimizer: ['...', new CssMinimizerPlugin()],

Review comment:
       Might not make a difference, but the [example](https://webpack.js.org/configuration/optimization/) in the docs places the ellipsis after the plugin, in which case this would be:
   ```js
       minimizer: [new CssMinimizerPlugin(), '...'],
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org