You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Adam Winer (JIRA)" <de...@myfaces.apache.org> on 2006/04/20 19:20:05 UTC

[jira] Created: (MYFACES-1289) selectBooleanCheckbox does not call endElement("input")

selectBooleanCheckbox does not call endElement("input")
-------------------------------------------------------

         Key: MYFACES-1289
         URL: http://issues.apache.org/jira/browse/MYFACES-1289
     Project: MyFaces Core
        Type: Bug

  Components: JSR-127  
    Versions: 1.1.2    
    Reporter: Adam Winer


HtmlCheckboxRendererBase.renderCheckbox() uses writeText("") to try to close up the input;  that's incorrect.  It should use endElement("input").  This bug generates a bunch of warnings when using MyFaces with ADF Faces, and also will generate invalid XHTML.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Closed: (MYFACES-1289) selectBooleanCheckbox does not call endElement("input")

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-1289?page=all ]
     
Matthias Weßendorf closed MYFACES-1289:
---------------------------------------

    Fix Version: 1.1.3-SNAPSHOT
     Resolution: Fixed

Thanks Adam for reporting this.

> selectBooleanCheckbox does not call endElement("input")
> -------------------------------------------------------
>
>          Key: MYFACES-1289
>          URL: http://issues.apache.org/jira/browse/MYFACES-1289
>      Project: MyFaces Core
>         Type: Bug

>   Components: JSR-127
>     Versions: 1.1.2
>     Reporter: Adam Winer
>     Assignee: Matthias Weßendorf
>      Fix For: 1.1.3-SNAPSHOT

>
> HtmlCheckboxRendererBase.renderCheckbox() uses writeText("") to try to close up the input;  that's incorrect.  It should use endElement("input").  This bug generates a bunch of warnings when using MyFaces with ADF Faces, and also will generate invalid XHTML.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (MYFACES-1289) selectBooleanCheckbox does not call endElement("input")

Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1289?page=comments#action_12375399 ] 

Adam Winer commented on MYFACES-1289:
-------------------------------------

Patch:

Index: core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java
===================================================================
--- core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java    (revision 394022)
+++ core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlCheckboxRendererBase.java    (working copy)
@@ -254,7 +254,9 @@
         if (isDisabled(facesContext, uiComponent)) {
             writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
         }
-        writer.writeText("", null); // close input
+
+        writer.endElement(HTML.INPUT_ELEM);
+
         if ((label != null) && (label.length() > 0)) {
             writer.write(HTML.NBSP_ENTITY);
             writer.writeText(label, null);


> selectBooleanCheckbox does not call endElement("input")
> -------------------------------------------------------
>
>          Key: MYFACES-1289
>          URL: http://issues.apache.org/jira/browse/MYFACES-1289
>      Project: MyFaces Core
>         Type: Bug

>   Components: JSR-127
>     Versions: 1.1.2
>     Reporter: Adam Winer

>
> HtmlCheckboxRendererBase.renderCheckbox() uses writeText("") to try to close up the input;  that's incorrect.  It should use endElement("input").  This bug generates a bunch of warnings when using MyFaces with ADF Faces, and also will generate invalid XHTML.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (MYFACES-1289) selectBooleanCheckbox does not call endElement("input")

Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-1289?page=all ]

Adam Winer updated MYFACES-1289:
--------------------------------

    Status: Patch Available  (was: Open)

> selectBooleanCheckbox does not call endElement("input")
> -------------------------------------------------------
>
>          Key: MYFACES-1289
>          URL: http://issues.apache.org/jira/browse/MYFACES-1289
>      Project: MyFaces Core
>         Type: Bug

>   Components: JSR-127
>     Versions: 1.1.2
>     Reporter: Adam Winer

>
> HtmlCheckboxRendererBase.renderCheckbox() uses writeText("") to try to close up the input;  that's incorrect.  It should use endElement("input").  This bug generates a bunch of warnings when using MyFaces with ADF Faces, and also will generate invalid XHTML.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira