You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/05/16 11:49:13 UTC

[GitHub] [orc] coderex2522 commented on pull request #1114: ORC-1170:[C++] Optimize the RowReader::seekToRow function

coderex2522 commented on PR #1114:
URL: https://github.com/apache/orc/pull/1114#issuecomment-1127572066

   > LGTM. It'd be nice if we can have a more specifit commit tittle. We are optimzing the case seeking within the same stripe. Seeking within the same RowGroup is not optimized in this PR. So having a title like "[ORC-1170](https://issues.apache.org/jira/browse/ORC-1170):[C++] Optimize seeking within the same stripe" seems better to me.
   
   I think seeking within the same stripe  is inclusive of  seeking withing the same RowGroup. Seeking withing the same RowGroup will also call function startNextStripe under the original implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org