[GitHub] [maven-jlink-plugin] rfscholte commented on a change in pull request #9: [MJLINK-50] -Upgrade to Java 11

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #9:
URL: https://github.com/apache/maven-jlink-plugin/pull/9#discussion_r513751225



##########
File path: pom.xml
##########
@@ -132,6 +131,16 @@
   <build>
     <pluginManagement>
       <plugins>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-compiler-plugin</artifactId>
+          <version>3.8.1</version>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-plugin-plugin</artifactId>
+          <version>3.6.0</version>

Review comment:
       We want to keep the plugin useful for as many maven version as possible. Most likely this plugin doesn't use any feature that requires 3.6.3. Recently we've decided to change the minimum for plugin from 3.0 to 3.1.0




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org