You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/09 09:54:59 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #460: feat: support ungroup in manager api
liuxiran opened a new pull request #460:
URL: https://github.com/apache/apisix-dashboard/pull/460
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
1. this pr could Independently resolve issue #452
1. this pr could also resolve the ci error in pr #450
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
1. refer to the https://github.com/apache/apisix-dashboard/issues/431#issuecomment-684158042, user could ungroup a route which is already in a routeGroup.
1. routeGroup is not a required item when create/edit the route
1. decouple api and front-end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #460: feat: support ungroup in manager api
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #460:
URL: https://github.com/apache/apisix-dashboard/pull/460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #460: feat: support ungroup in manager api
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #460:
URL: https://github.com/apache/apisix-dashboard/pull/460#issuecomment-689920798
need test cases for changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #460: feat: support ungroup in manager api
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #460:
URL: https://github.com/apache/apisix-dashboard/pull/460#issuecomment-690338834
@liuxiran Please add test cases, so we could move forward this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #460: feat: support ungroup in manager api
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #460:
URL: https://github.com/apache/apisix-dashboard/pull/460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org