You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/29 08:09:39 UTC

[GitHub] [pulsar] tjiuming opened a new pull request, #16866: [broker][monitoring][fix] fix `pulsar_subscription_msg_ack_rate`

tjiuming opened a new pull request, #16866:
URL: https://github.com/apache/pulsar/pull/16866

   ### Motivation
   
   Currently, in branch 2.9, when set `exposeTopicLevelMetricsInPrometheus=true` and `exposeConsumerLevelMetricsInPrometheus=true`,  the value of `pulsar_subscription_msg_ack_rate` is always 0.0. The PR is supposed to fix it.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tjiuming commented on pull request #16866: [broker][monitoring][fix] fix `pulsar_subscription_msg_ack_rate`

Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #16866:
URL: https://github.com/apache/pulsar/pull/16866#issuecomment-1200451457

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] HQebupt commented on pull request #16866: [broker][monitoring][fix] fix `pulsar_subscription_msg_ack_rate`

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #16866:
URL: https://github.com/apache/pulsar/pull/16866#issuecomment-1200121093

   Why not cherry pick from master ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tjiuming commented on pull request #16866: [broker][monitoring][fix] fix `pulsar_subscription_msg_ack_rate`

Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #16866:
URL: https://github.com/apache/pulsar/pull/16866#issuecomment-1200419223

   > Why not cherry pick from master ?
   
   Toooooo many conflicts to cherry-pick


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tjiuming commented on pull request #16866: [broker][monitoring][fix] fix `pulsar_subscription_msg_ack_rate`

Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #16866:
URL: https://github.com/apache/pulsar/pull/16866#issuecomment-1201497195

   @mattisonchao PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui merged pull request #16866: [broker][monitoring][fix] fix `pulsar_subscription_msg_ack_rate`

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16866:
URL: https://github.com/apache/pulsar/pull/16866


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org