You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by hequn8128 <gi...@git.apache.org> on 2017/04/13 12:13:12 UTC

[GitHub] flink issue #3696: [FLINK-6090] [table] Add RetractionRule at the stage of d...

Github user hequn8128 commented on the issue:

    https://github.com/apache/flink/pull/3696
  
    hi @fhueske , Thanks for your review and refactorings. I think it's pretty good and I have learned a lot form it. I left a few comments in your PR.
    
    As for the hardcode problem, I think you are right, it's better to extend the DataStreamRel with a couple of methods. I have added some methods in DataStreamRel, so you can use them directly when you squash your PR into my commit, thx~
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---