You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/08/31 22:21:42 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #274: Multiple Updates
Shanedell opened a new pull request, #274:
URL: https://github.com/apache/daffodil-vscode/pull/274
Multiple Updates:
- Make launch wizard display properly when using light themes.
- No longer closer the hexview once debug has ended.
Closes #266
Closes #267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #274: Multiple Updates
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on PR #274:
URL: https://github.com/apache/daffodil-vscode/pull/274#issuecomment-1239725307
@mbeckerle, will you review this PR, we need your vote, and these address issues that you've found during the last release vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #274: Multiple Updates
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #274:
URL: https://github.com/apache/daffodil-vscode/pull/274#discussion_r961065076
##########
src/styles/styles.css:
##########
@@ -86,7 +86,7 @@
}
.setting-div {
- color: white;
+ /* color: white; */
Review Comment:
Don't bother commenting this out, just delete this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #274: Multiple Updates
Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #274:
URL: https://github.com/apache/daffodil-vscode/pull/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #274: Multiple Updates
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #274:
URL: https://github.com/apache/daffodil-vscode/pull/274#issuecomment-1239788873
@tuxji Does the commit look better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #274: Multiple Updates
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on PR #274:
URL: https://github.com/apache/daffodil-vscode/pull/274#issuecomment-1235581137
@stevedlawrence and @mbeckerle, will you guys review this PR? This addresses a couple of (minor) issues that Mike brought to our attention in his review of version 1.1.0 when it went up for a release vote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #274: Multiple Updates
Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #274:
URL: https://github.com/apache/daffodil-vscode/pull/274#issuecomment-1238419614
> +1
>
> Note, In general I would really prefer a single PR per issue, even when they are small one liners. When you include multiple changes in a single PR the commit subject is something generic like "multiple updates" which is very unhelpful when looking back at history. I would much rather see two PRs and commits with appropriate commit messages.
Yeah this makes sense I will make sure to do them as single PRs from now one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org