[GitHub] [helix] pkuwm opened a new pull request #537: Implement increment() method in CountMetric class.

[GitBox <gi...@apache.org>]

pkuwm opened a new pull request #537: Implement increment() method in CountMetric class.
URL: https://github.com/apache/helix/pull/537
 
 
   ### Issues
   
   - [x]  My PR addresses the following Helix issues and references them in the PR title:
   Fix #536.
   
   ### Description
   
   - [x]  Here are some details about my PR, including screenshots of any UI changes:
   Abstract method increaseCount() in CountMetric is a generic method used in inherited classes. We should implement this method in CountMetric to reduce duplicate code in inherited classes.
   
   ### Tests
   
   - [x]  The following tests are written for this issue:
   No new test added.
   
   - [x]  The following is the result of the "mvn test" command on the appropriate module:
   Run mvn build 
   
   [INFO] Reactor Summary for Apache Helix 0.9.2-SNAPSHOT:
   [INFO]
   [INFO] Apache Helix ....................................... SUCCESS [  1.068 s]
   [INFO] Apache Helix :: Core ............................... SUCCESS [ 12.887 s]
   [INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [  1.621 s]
   [INFO] Apache Helix :: Restful Interface .................. SUCCESS [  3.354 s]
   [INFO] Apache Helix :: HelixAgent ......................... SUCCESS [  0.781 s]
   [INFO] Apache Helix :: Recipes ............................ SUCCESS [  0.026 s]
   [INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [  0.611 s]
   [INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [  0.726 s]
   [INFO] Apache Helix :: Recipes :: distributed lock manager  SUCCESS [  0.603 s]
   [INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [  0.579 s]
   [INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [  0.563 s]
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   
   ### Commits
   
   - [x]  My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
   Subject is separated from body by a blank line
   Subject is limited to 50 characters (not including Jira issue reference)
   Subject does not end with a period
   Subject uses the imperative mood ("add", not "adding")
   Body wraps at 72 characters
   Body explains "what" and "why", not "how"
   Documentation
   
     In case of new functionality, my PR adds documentation in the following wiki page:
   (Link the GitHub wiki you added)
   
   ### Code Quality
   
   - [x]  My diff has been formatted using helix-style-intellij.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org