You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2017/03/01 18:22:11 UTC

Re: Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46980/#review167381
-----------------------------------------------------------



Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews.

- Joris Van Remoortere


On May 5, 2016, 2:44 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46980/
> -----------------------------------------------------------
> 
> (Updated May 5, 2016, 2:44 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Jie Yu.
> 
> 
> Bugs: MESOS-5310
>     https://issues.apache.org/jira/browse/MESOS-5310
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented adding a cni network config via 'cni/config' endpoint.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp a06bb89a7a79a62949a48274df806f9f95da09e7 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp dae369aadb940150aa806b28d9269e3d88cf57ed 
> 
> 
> Diff: https://reviews.apache.org/r/46980/diff/2/
> 
> 
> Testing
> -------
> 
> Used `curl` to add a new CNI network configuration via 'cni/config' endpoint, and then used `mesos-execute` to launch a container to join the newly added CNI network successfully.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>