You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by GitBox <gi...@apache.org> on 2020/06/30 11:16:25 UTC
[GitHub] [felix-dev] amitjoy commented on a change in pull request #29: [FELIX-6265] Replaced Quartz with custom Cron Scheduler
amitjoy commented on a change in pull request #29:
URL: https://github.com/apache/felix-dev/pull/29#discussion_r447604922
##########
File path: healthcheck/core/src/main/java/org/apache/felix/hc/core/impl/executor/async/AsyncHealthCheckExecutor.java
##########
@@ -138,13 +135,7 @@ private boolean scheduleHealthCheck(HealthCheckMetadata descriptor) {
AsyncJob healthCheckAsyncJob = null;
if (isAsyncCron(descriptor)) {
-
- try {
- healthCheckAsyncJob = new AsyncQuartzCronJob(getAsyncJob(descriptor), quartzCronSchedulerProvider, "job-hc-" + descriptor.getServiceId(), "async-healthchecks", descriptor.getAsyncCronExpression());
- } catch(ClassNotFoundException|NoClassDefFoundError e) {
- LOG.warn("Can not schedule async health check '{}' with cron expression '{}' since quartz library is not on classpath", descriptor.getName(), descriptor.getAsyncCronExpression());
- return false;
- }
+ healthCheckAsyncJob = new AsyncCronJob(getAsyncJob(descriptor), healthCheckCronScheduler, "job-hc-" + descriptor.getServiceId(), descriptor.getAsyncCronExpression());
Review comment:
There was a long discussion earlier to use specific formatting standard for Felix but as far as I got to know, it is not decided and that's why I wrote everything without any formatting applied. In Eclipse, the changes look good but due to formatting standard in GitHub, it looks different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org