[GitHub] [iotdb] lancelly commented on a diff in pull request #8957: [IOTDB-5449] Allow query scheduler to receive more tasks

["lancelly (via GitHub)" <gi...@apache.org>]

lancelly commented on code in PR #8957:
URL: https://github.com/apache/iotdb/pull/8957#discussion_r1093202782


##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/queue/IndexedBlockingQueue.java:
##########
@@ -67,31 +73,38 @@ public synchronized E poll() throws InterruptedException {
     }
     E output = pollFirst();
     size--;
+    tryToAddBlockedTask();
     return output;
   }
 
   /**
    * Push an element to the queue. The new element position is determined by the implementation. If
-   * the queue size has been reached the maxCapacity, or the queue has already contained an element
-   * with the same ID, an {@link IllegalStateException} will be thrown. If the element is null, an
-   * {@link NullPointerException} will be thrown.
+   * the queue has already contained an element with the same ID, an {@link IllegalStateException}
+   * will be thrown. If the queue size has been reached the maxCapacity, the element will wait a

Review Comment:
   If the queue size has been reached => If the queue size has reached



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org