You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "no1wudi (via GitHub)" <gi...@apache.org> on 2023/07/17 04:13:59 UTC
[GitHub] [nuttx-apps] no1wudi opened a new pull request, #1842: tools: Merge WASM_BUILD and WASM_BUILD_ONLY
no1wudi opened a new pull request, #1842:
URL: https://github.com/apache/nuttx-apps/pull/1842
## Summary
By make WASM_BUILD as a three state variable: y , n or both.
## Impact
If any wasm runtime enabled, some apps like hello/coremark, will not be built into nsh as native app.
## Testing
CI and local machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1842: tools: Merge WASM_BUILD and WASM_BUILD_ONLY
Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi commented on code in PR #1842:
URL: https://github.com/apache/nuttx-apps/pull/1842#discussion_r1265093882
##########
Application.mk:
##########
@@ -285,12 +296,8 @@ distclean:: clean
-include Make.dep
-# Default values for WASM_BUILD from Application.mk
-
-WASM_BUILD ?= n
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] no1wudi commented on a diff in pull request #1842: tools: Merge WASM_BUILD and WASM_BUILD_ONLY
Posted by "no1wudi (via GitHub)" <gi...@apache.org>.
no1wudi commented on code in PR #1842:
URL: https://github.com/apache/nuttx-apps/pull/1842#discussion_r1265094169
##########
Application.mk:
##########
@@ -97,14 +97,25 @@ endif
DO_REGISTRATION = y
-ifeq ($(PROGNAME),)
- DO_REGISTRATION = n
+# Default values for WASM_BUILD from Application.mk, it's a three state variable:
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1842: tools: Merge WASM_BUILD and WASM_BUILD_ONLY
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1842:
URL: https://github.com/apache/nuttx-apps/pull/1842#discussion_r1264923332
##########
Application.mk:
##########
@@ -97,14 +97,25 @@ endif
DO_REGISTRATION = y
-ifeq ($(PROGNAME),)
- DO_REGISTRATION = n
+# Default values for WASM_BUILD from Application.mk, it's a three state variable:
+# y - build wasm module only
+# n - don't build wasm module
+# both - build wasm module and native module
+
+WASM_BUILD ?= n
+
+ifneq ($(CONFIG_INTERPRETERS_WAMR)$(CONFIG_INTERPRETERS_WASM)$(CONFIG_INTERPRETERS_TOYWASM),)
+HAVE_WASM_RUNTIME = y
endif
-ifeq ($(WASM_BUILD),y)
-ifeq ($(WASM_BUILD_ONLY),y)
+ifeq ($(PROGNAME),)
DO_REGISTRATION = n
endif
+
+ifeq ($(HAVE_WASM_RUNTIME),y)
+ ifeq ($(WASM_BUILD),y)
+ DO_REGISTRATION = n
Review Comment:
remove the extra spaces
##########
Application.mk:
##########
@@ -97,14 +97,25 @@ endif
DO_REGISTRATION = y
-ifeq ($(PROGNAME),)
- DO_REGISTRATION = n
+# Default values for WASM_BUILD from Application.mk, it's a three state variable:
Review Comment:
let's move all wasm related stuff to tools/Wasm.mk
##########
Application.mk:
##########
@@ -285,12 +296,8 @@ distclean:: clean
-include Make.dep
-# Default values for WASM_BUILD from Application.mk
-
-WASM_BUILD ?= n
Review Comment:
move the check to tools/Wasm.mk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1842: tools: Merge WASM_BUILD and WASM_BUILD_ONLY
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #1842:
URL: https://github.com/apache/nuttx-apps/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org