You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/11/28 17:37:04 UTC
[Bug 55826] New: Unsynchronised concurrent accesses to list in field
RespTimeGraphVisualizer.internalList
https://issues.apache.org/bugzilla/show_bug.cgi?id=55826
Bug ID: 55826
Summary: Unsynchronised concurrent accesses to list in field
RespTimeGraphVisualizer.internalList
Product: JMeter
Version: 2.10
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: bob@contemplateltd.com
We ran our static analysis tool ThreadSafe [1] on version 2.10 of JMeter, which
appeared to uncover a couple of concurrency issues. One of the most interesting
was a potential for unsynchronised concurrent accesses to the LinkedList stored
in the field RespTimeGraphVisualizer.internalList.
The list stored in this field can be read from the method
RespTimeGraphVisualize.actionPerformed(..), which will be called by the Swing
UI thread, and is also modified by the method RespTimeGraphVisualizer.add(..),
is a call-graph descendent of the run() method of the thread
AsynchSampleSender.Worker thread.
Therefore, it is possible that incorrect data may be read from the list by the
UI thread, due to the lack of synchronisation.
We're not sure that this can actually result in a user-visible bug, but we
thought you'd like to know.
We are also planning to use this finding as an example of Android-related
concurrency mistakes in an article about ThreadSafe. Obviously, if you, as the
developers of JMeter, have any objections to our using this as an example, then
we won't.
[1] ThreadSafe is a static analysis tool for Java concurrency, developed by
Contemplate Ltd.:
http://www.contemplateltd.com/
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55826] Unsynchronised concurrent accesses to list in field
RespTimeGraphVisualizer.internalList
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55826
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
OS|Linux |All
--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks for report.
Regarding use of this example, can you ask the question on dev list ?
Thank you
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55826] Unsynchronised concurrent accesses to list in field
RespTimeGraphVisualizer.internalList
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55826
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |p.mouawad@ubik-ingenierie.c
| |om
--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Fri Nov 29 22:29:00 2013
New Revision: 1546654
URL: http://svn.apache.org/r1546654
Log:
Bug 55826 - Unsynchronised concurrent accesses to list in field
RespTimeGraphVisualizer.internalList
Bugzilla Id: 55826
Modified:
jmeter/trunk/src/components/org/apache/jmeter/visualizers/RespTimeGraphVisualizer.java
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 55826] Unsynchronised concurrent accesses to list in field
RespTimeGraphVisualizer.internalList
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55826
--- Comment #1 from Bob Atkey <bo...@contemplateltd.com> ---
I wrote:
> We are also planning to use this finding as an example of Android-related
> concurrency mistakes in an article about ThreadSafe.
Obviously, "Android-related" was a mistake here. I meant to write
"Java-related". Sorry about that.
--
You are receiving this mail because:
You are the assignee for the bug.