You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/03 16:39:44 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #894: MINIFICPP-1351 fix PublishKafka::notifyStop race condition over connection

szaszm commented on a change in pull request #894:
URL: https://github.com/apache/nifi-minifi-cpp/pull/894#discussion_r483114073



##########
File path: extensions/librdkafka/PublishKafka.h
##########
@@ -125,7 +125,7 @@ class PublishKafka : public core::Processor {
   utils::Regex attributeNameRegex_;
 
   std::atomic<bool> interrupted_{false};
-  std::mutex messages_mutex_;
+  std::mutex messages_mutex_;  // If both connection_mutex_ and messages_mutex_ are needed, always take connection_mutex_ first to avoid deadlock

Review comment:
       Letting others learn from my mistakes :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org