You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Gabriella Lotz (Code Review)" <ge...@cloudera.org> on 2026/08/12 12:31:21 UTC
[kudu-CR] remove std::move on optional deadline
Gabriella Lotz has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24680
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
remove std::move on optional<MonoTime> deadline
MonoTime wraps a single int64_t, so std::move on the deadline
does nothing beyond a plain copy. clang-tidy flags these sites
in rebalancer_tool.cc as performance-move-const-arg; drop the
std::move.
No behavior change.
Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
---
M src/kudu/tools/rebalancer_tool.cc
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/24680/1
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
[kudu-CR] remove std::move on optional deadline
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2877/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 13:07:11 +0000
Gerrit-HasComments: No
[kudu-CR] remove std::move on optional deadline
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
Patch Set 2: Verified+1
TSAN: unrelated failure of known flaky tests
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 19:42:06 +0000
Gerrit-HasComments: No
[kudu-CR] remove std::move on optional deadline
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2877/
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 1
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Aug 2026 12:31:27 +0000
Gerrit-HasComments: No
[kudu-CR] remove std::move on optional deadline
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2879/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 15:06:09 +0000
Gerrit-HasComments: No
[kudu-CR] remove std::move on optional deadline
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24680
to look at the new patch set (#2).
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
remove std::move on optional<MonoTime> deadline
MonoTime wraps a single int64_t, so std::move on the deadline
does nothing beyond a plain copy. clang-tidy flags these sites
in rebalancer_tool.cc as performance-move-const-arg; drop the
std::move.
No behavior change.
Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
---
M src/kudu/tools/rebalancer_tool.cc
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/24680/2
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] remove std::move on optional deadline
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 19:42:20 +0000
Gerrit-HasComments: No
[kudu-CR] remove std::move on optional deadline
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
Patch Set 2: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2879/
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 14:17:08 +0000
Gerrit-HasComments: No
[kudu-CR] remove std::move on optional deadline
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 2
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] remove std::move on optional deadline
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24680 )
Change subject: remove std::move on optional<MonoTime> deadline
......................................................................
remove std::move on optional<MonoTime> deadline
MonoTime wraps a single int64_t, so std::move on the deadline
does nothing beyond a plain copy. clang-tidy flags these sites
in rebalancer_tool.cc as performance-move-const-arg; drop the
std::move.
No behavior change.
Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Reviewed-on: http://gerrit.cloudera.org:8080/24680
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/tools/rebalancer_tool.cc
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/24680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I468f3cfd22de98d51c725dcecc15ed35e4cfe8ad
Gerrit-Change-Number: 24680
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>