[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #56: avoid duplicate docbot comment

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #56:
URL: https://github.com/apache/pulsar-test-infra/pull/56#discussion_r945165238


##########
docbot/main.go:
##########
@@ -309,6 +309,11 @@ func (a *Action) onPullRequestOpenedOrEdited() error {
 		}
 	}
 
+	if _, exist := currentLabelsSet[a.config.GetLabelMissing()]; exist && checkedCount == 0 {

Review Comment:
   I can move this section inside `if a.config.GetEnableLabelMissing() && checkedCount == 0`, but cannot after `AddLabelsToIssue`. Otherwise, the docbot will never create comment because we check label missing just after we add it, and it will be always true.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org