You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zjffdu <gi...@git.apache.org> on 2015/11/16 05:10:54 UTC
[GitHub] spark pull request: [SPARK-11747][EXAMPLES] Can not specify input ...
GitHub user zjffdu opened a pull request:
https://github.com/apache/spark/pull/9725
[SPARK-11747][EXAMPLES] Can not specify input path in python logistic_regression example under ml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjffdu/spark SPARK-11747
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9725
----
commit 099f44f6f20f6929a37fb21ca00ca8eb2d17986d
Author: Jeff Zhang <zj...@apache.org>
Date: 2015-11-16T03:39:58Z
[SPARK-11747][EXAMPLES] Can not specify input path in python logistic_regression example under ml
commit 7209ed1c25eb9606dff59a92fe6b1f42dcc7b47f
Author: Jeff Zhang <zj...@apache.org>
Date: 2015-11-16T04:08:55Z
minor change in comment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11747][EXAMPLES] Can not specify input ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9725#discussion_r44906808
--- Diff: examples/src/main/python/ml/logistic_regression.py ---
@@ -28,20 +28,20 @@
"""
A simple example demonstrating a logistic regression with elastic net regularization Pipeline.
Run with:
- bin/spark-submit examples/src/main/python/ml/logistic_regression.py
+ bin/spark-submit examples/src/main/python/ml/logistic_regression.py <file> <iterations>
"""
if __name__ == "__main__":
- if len(sys.argv) > 1:
- print("Usage: logistic_regression", file=sys.stderr)
+ if len(sys.argv) != 3:
+ print("Usage: logistic_regression <file> <iterations>", file=sys.stderr)
--- End diff --
Now, you are requiring the caller to specify the location of the input, whereas before it would default conveniently to the sample data file. I think you need to support the existing behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11747][EXAMPLES] Can not specify input ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9725#issuecomment-156912410
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/45976/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11747][EXAMPLES] Can not specify input ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9725#issuecomment-156911128
**[Test build #45976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45976/consoleFull)** for PR 9725 at commit [`7209ed1`](https://github.com/apache/spark/commit/7209ed1c25eb9606dff59a92fe6b1f42dcc7b47f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11747][EXAMPLES] Can not specify input ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9725#issuecomment-156912408
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11747][EXAMPLES] Can not specify input ...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the pull request:
https://github.com/apache/spark/pull/9725#issuecomment-156978511
Found other places also hard coded
* DecisionTreeRegressionExample
* DecisionTreeClassificationExample
* NaiveBayesExample
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-11747][EXAMPLES] Can not specify input ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9725#issuecomment-156912342
**[Test build #45976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45976/consoleFull)** for PR 9725 at commit [`7209ed1`](https://github.com/apache/spark/commit/7209ed1c25eb9606dff59a92fe6b1f42dcc7b47f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org