[GitHub] [pulsar-client-node] shibd commented on a diff in pull request #250: Supoort prebuild macos-arm64 arch binaries.

[GitBox <gi...@apache.org>]

shibd commented on code in PR #250:
URL: https://github.com/apache/pulsar-client-node/pull/250#discussion_r1036663346


##########
.github/workflows/ci-build-release-napi.yml:
##########
@@ -38,16 +38,24 @@ jobs:
           path: pkg/mac/build
           key: ${{ runner.os }}-${{ matrix.arch }}-mac-${{ hashFiles('pkg/mac/build-cpp-deps-lib.sh') }}
 
+      - name: Add arch env vars
+        run: |
+          if [ "${{ matrix.arch }}" = "x64" ]; then
+            echo "ARCH=x86_64" >> $GITHUB_ENV
+          else
+            echo "ARCH=${{ matrix.target }}" >> $GITHUB_ENV

Review Comment:
   Oh, Wrong written here. 
   
   As for why CI can pass, it is because the default value of arch in the `common.sh` is arm64



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org