[GitHub] HyukjinKwon edited a comment on issue #23620: [SPARK-26696][SQL] Makes Dataset encoder public

[GitBox <gi...@apache.org>]

HyukjinKwon edited a comment on issue #23620: [SPARK-26696][SQL] Makes Dataset encoder public
URL: https://github.com/apache/spark/pull/23620#issuecomment-462410275
 
 
   Thanks. So, am I being correct the only targeted usecase by this fix is:
   
   ```scala
   def foo[A](ds: Dataset[A]): Dataset[A] =
     ds.toDF().as[A](ds.encoder)
   ```
   
   vs
   
   ```scala
   def foo[A: Encoder](ds: Dataset[A]): Dataset[A] =
     ds.toDF().as[A](implicitly[Encoder[A]])
   ```
   
   ? If so, I don't feel strongly about this PR. Let me leave it to you guys then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org