You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/02 01:56:30 UTC

[GitHub] [kafka] guozhangwang opened a new pull request, #12468: KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest

guozhangwang opened a new pull request, #12468:
URL: https://github.com/apache/kafka/pull/12468

   In the current test, we check for tag distribution immediately after everyone is on the running state, however due to the fact of the follow-up rebalances, "everyone is now in running state" does not mean that the cluster is now stable. In fact, a follow-up rebalance may occur, upon which the local thread metadata would return empty which would cause the distribution verifier to fail.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on pull request #12468: KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on PR #12468:
URL: https://github.com/apache/kafka/pull/12468#issuecomment-1203477606

   Thanks @divijvaidya , I've fixed the mistakenly modified code logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang merged pull request #12468: KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest

Posted by GitBox <gi...@apache.org>.
guozhangwang merged PR #12468:
URL: https://github.com/apache/kafka/pull/12468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12468: KAFKA-13877: Fix flakiness in RackAwarenessIntegrationTest

Posted by GitBox <gi...@apache.org>.
guozhangwang commented on code in PR #12468:
URL: https://github.com/apache/kafka/pull/12468#discussion_r935046325


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -1267,7 +1267,7 @@ public RecordQueue createQueue(final TopicPartition partition) {
             final SourceNode<?, ?> source = topology.source(partition.topic());
             if (source == null) {
                 throw new TopologyException(
-                        "Topic is unknown to the topology. " +
+                        "Topic " + partition.topic() + " is unknown to the topology. " +

Review Comment:
   This is piggy-backed improvement when I tried to debug the failure: it's better to log the missing topic name as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org