[jira] [Commented] (CASSANDRA-4994) cassandra.yaml - actually separate server_encryption_options and client_encryption_options

["Vijay (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504454#comment-13504454 ] 

Vijay commented on CASSANDRA-4994:
----------------------------------

Hi Jonathan will do,

LGTM, committed with minor nit (made EncryptionOptions to abstract).
                
> cassandra.yaml - actually separate server_encryption_options and client_encryption_options
> ------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4994
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4994
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.2.0 beta 2
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0 rc1
>
>         Attachments: 4994.txt
>
>
> Currently they have different names but use the same option names, which doesn't make sense for two reasons:
> - internode_encryption: none/all doesn't make sense for client encryption. Should be 'enabled: true/false'
> - truststore and truststore_password are not used by Cassandra for client encryption and shouldn't be present in client_encryption_options.
> Moved type-dependent options to either ServerEncryptionOptions or ClientEncryptionOptions. Left truststore and truststore_password in EncryptionOptions for use by Stress and CLI (but removed them from cassandra.yaml).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira