You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Anil K Patel (JIRA)" <ji...@apache.org> on 2007/05/07 22:03:15 UTC

[jira] Created: (OFBIZ-967) Enhance UtilHttp.getParameterMap method to also include values from Request Attributes

Enhance UtilHttp.getParameterMap method to also include values from Request Attributes
--------------------------------------------------------------------------------------

                 Key: OFBIZ-967
                 URL: https://issues.apache.org/jira/browse/OFBIZ-967
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
            Reporter: Anil K Patel


It might be nice to refactor the code out of the screen widget to prepare the combined Map in UtilHttp (which includes in this order of priority: request attributes, request parameters, session attributes, application attributes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-967) Enhance UtilHttp.getParameterMap method to also include values from Request Attributes

Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya updated OFBIZ-967:
--------------------------------------

    Attachment: UtilHttp_getParameterMap.patch

Here is the patch.

Regards
Ashish Vijaywargiya

> Enhance UtilHttp.getParameterMap method to also include values from Request Attributes
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-967
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-967
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Anil K Patel
>         Attachments: UtilHttp_getParameterMap.patch
>
>
> It might be nice to refactor the code out of the screen widget to prepare the combined Map in UtilHttp (which includes in this order of priority: request attributes, request parameters, session attributes, application attributes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (OFBIZ-967) Enhance UtilHttp.getParameterMap method to also include values from Request Attributes

Posted by "Andrew Zeneski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Zeneski closed OFBIZ-967.
--------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

I had to refactor this to remain backwards compatible. The getParameterMap() method is pretty sure you will only get request parameters and I know a couple of places this would surely break. Instead, I changed the method to be getCombinedMap() and updated the ScreenRenderer to call this method instead.

> Enhance UtilHttp.getParameterMap method to also include values from Request Attributes
> --------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-967
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-967
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Anil K Patel
>             Fix For: SVN trunk
>
>         Attachments: UtilHttp_getParameterMap.patch
>
>
> It might be nice to refactor the code out of the screen widget to prepare the combined Map in UtilHttp (which includes in this order of priority: request attributes, request parameters, session attributes, application attributes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.