[jira] [Commented] (HIVE-24649) Optimise Hive::addWriteNotificationLog for large data inserts

["Rajesh Balamohan (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-24649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515732#comment-17515732 ] 

Rajesh Balamohan commented on HIVE-24649:
-----------------------------------------

Yes [~maheshk114]. https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3217 has batching enabled which reduce the load. I haven't personally tried benchmarking with HIVE-25025, but batching should definitely should help reducing the load. We can mark this closed and revisit if problem resurfaces.

> Optimise Hive::addWriteNotificationLog for large data inserts
> -------------------------------------------------------------
>
>                 Key: HIVE-24649
>                 URL: https://issues.apache.org/jira/browse/HIVE-24649
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>            Reporter: Rajesh Balamohan
>            Priority: Major
>              Labels: performance
>
> When loading dynamic partition with large dataset, it spends lot of time in "Hive::loadDynamicPartitions --> addWriteNotificationLog".
> Though it is for same for same table, it ends up loading table and partition details for every partition and writes to notification log.
> Also, "Partition" details may be already present in {{PartitionDetails}} object in {{Hive::loadDynamicPartitions}}. This is unnecessarily recomputed again in {{HiveMetaStore::add_write_notification_log}}
>  
> Lines of interest:
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L3028
> https://github.com/apache/hive/blob/89073a94354f0cc14ec4ae0a43e05aae29276b4d/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L8500
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)