You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/11 05:55:51 UTC
Review Request 28931: CLOUDSTACK:8058: Fix test_reset_ssh_keypair.py
for EIP setup
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28931/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8058
https://issues.apache.org/jira/browse/CLOUDSTACK-8058
Repository: cloudstack-git
Description
-------
The publicIP of the VM changes on EIP setup after stop and start operation. Hence it is necessary that on such setup, new publicip should be used for the SSH.
Made the necessary changes to use the new publicip.
Diffs
-----
test/integration/component/test_reset_ssh_keypair.py 370e9a8
Diff: https://reviews.apache.org/r/28931/diff/
Testing
-------
Yes.
On Advanced zone:
Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS ===
ok
Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS ===
ok
Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS ===
ok
Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS ===
ok
Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS ===
ok
Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS ===
ok
Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS ===
ok
Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS ===
ok
Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS ===
ok
Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 4553.103s
OK
On EIP setup (basic zone):
Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS ===
ok
Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS ===
ok
Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS ===
ok
Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS ===
ok
Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS ===
ok
Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS ===
ok
Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS ===
ok
Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS ===
ok
Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS ===
ok
Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 3443.114s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 28931: CLOUDSTACK:8058: Fix
test_reset_ssh_keypair.py for EIP setup
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
> On Dec. 11, 2014, 12:22 p.m., SrikanteswaraRao Talluri wrote:
> > 9aefd9bf4f580dd5954520b6b53909b1f732b7f8 4.5
487bf5f57db72c3c462f2681610767daf95ac37e master
- SrikanteswaraRao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28931/#review64720
-----------------------------------------------------------
On Dec. 11, 2014, 4:55 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28931/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 4:55 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8058
> https://issues.apache.org/jira/browse/CLOUDSTACK-8058
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The publicIP of the VM changes on EIP setup after stop and start operation. Hence it is necessary that on such setup, new publicip should be used for the SSH.
>
> Made the necessary changes to use the new publicip.
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py 370e9a8
>
> Diff: https://reviews.apache.org/r/28931/diff/
>
>
> Testing
> -------
>
> Yes.
>
> On Advanced zone:
> Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS ===
> ok
> Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS ===
> ok
> Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 10 tests in 4553.103s
>
> OK
>
>
> On EIP setup (basic zone):
> Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS ===
> ok
> Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS ===
> ok
> Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 10 tests in 3443.114s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 28931: CLOUDSTACK:8058: Fix
test_reset_ssh_keypair.py for EIP setup
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28931/#review64720
-----------------------------------------------------------
Ship it!
9aefd9bf4f580dd5954520b6b53909b1f732b7f8 4.5
- SrikanteswaraRao Talluri
On Dec. 11, 2014, 4:55 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28931/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2014, 4:55 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8058
> https://issues.apache.org/jira/browse/CLOUDSTACK-8058
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The publicIP of the VM changes on EIP setup after stop and start operation. Hence it is necessary that on such setup, new publicip should be used for the SSH.
>
> Made the necessary changes to use the new publicip.
>
>
> Diffs
> -----
>
> test/integration/component/test_reset_ssh_keypair.py 370e9a8
>
> Diff: https://reviews.apache.org/r/28931/diff/
>
>
> Testing
> -------
>
> Yes.
>
> On Advanced zone:
> Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS ===
> ok
> Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS ===
> ok
> Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 10 tests in 4553.103s
>
> OK
>
>
> On EIP setup (basic zone):
> Verify API resetSSHKeyForVirtualMachine for non admin non root ... === TestName: test_01_reset_keypair_normal_user | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin non root ... === TestName: test_02_reset_keypair_domain_admin | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine for domain admin root ... === TestName: test_03_reset_keypair_root_admin | Status : SUCCESS ===
> ok
> Test Reset SSH keys for VM already having SSH key ... === TestName: test_01_reset_ssh_keys | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_02_reset_ssh_key_password_enabled_template | Status : SUCCESS ===
> ok
> Reset SSH key for VM having no SSH key ... === TestName: test_03_reset_ssh_with_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_04_reset_key_passwd_enabled_no_key | Status : SUCCESS ===
> ok
> Reset SSH keys for VM already having SSH key when VM is in running ... === TestName: test_05_reset_key_in_running_state | Status : SUCCESS ===
> ok
> Reset SSH keys for VM created from password enabled template and ... === TestName: test_06_reset_key_passwd_enabled_vm_running | Status : SUCCESS ===
> ok
> Verify API resetSSHKeyForVirtualMachine with incorrect parameters ... === TestName: test_07_reset_keypair_invalid_params | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 10 tests in 3443.114s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>