You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/01 02:14:51 UTC
[GitHub] [apisix] leslie-tsang opened a new pull request #5385: fix: fix ldap deps in `install-dependencies.sh`
leslie-tsang opened a new pull request #5385:
URL: https://github.com/apache/apisix/pull/5385
Signed-off-by: leslie <le...@icloud.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
* use `openldap-devel` instead of `libldap2-dev`, `libldap2-dev` don't exist on centos
* fix file lint in `t/plugin/ldap-auth.t`, add new line at the end of file
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5385: fix: fix ldap deps in `install-dependencies.sh`
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5385:
URL: https://github.com/apache/apisix/pull/5385#discussion_r739960917
##########
File path: utils/install-dependencies.sh
##########
@@ -24,10 +24,9 @@ function install_dependencies_with_yum() {
# add OpenResty source
sudo yum install yum-utils
sudo yum-config-manager --add-repo "https://openresty.org/package/${1}/openresty.repo"
- sudo yum check-update
Review comment:
When an update is available, `yum check-update` returns status code `100`, Which will break the execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5385: fix: fix ldap deps in `install-dependencies.sh`
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5385:
URL: https://github.com/apache/apisix/pull/5385#discussion_r739959639
##########
File path: utils/install-dependencies.sh
##########
@@ -24,10 +24,9 @@ function install_dependencies_with_yum() {
# add OpenResty source
sudo yum install yum-utils
sudo yum-config-manager --add-repo "https://openresty.org/package/${1}/openresty.repo"
- sudo yum check-update
Review comment:
Why remove this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5385: fix: fix ldap deps in `install-dependencies.sh`
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5385:
URL: https://github.com/apache/apisix/pull/5385#discussion_r740010223
##########
File path: utils/install-dependencies.sh
##########
@@ -24,10 +24,9 @@ function install_dependencies_with_yum() {
# add OpenResty source
sudo yum install yum-utils
sudo yum-config-manager --add-repo "https://openresty.org/package/${1}/openresty.repo"
- sudo yum check-update
Review comment:
IMO, `yum check-update` check whether there is an update or not would't bring any benefit for `install_dependencies_with_yum`.
`yum` don't need to update the repo cache after adding a new repo like `apt` does.
Shall we remove it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5385: fix: ldap deps in `install-dependencies.sh`
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5385:
URL: https://github.com/apache/apisix/pull/5385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5385: fix: fix ldap deps in `install-dependencies.sh`
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #5385:
URL: https://github.com/apache/apisix/pull/5385#discussion_r740010223
##########
File path: utils/install-dependencies.sh
##########
@@ -24,10 +24,9 @@ function install_dependencies_with_yum() {
# add OpenResty source
sudo yum install yum-utils
sudo yum-config-manager --add-repo "https://openresty.org/package/${1}/openresty.repo"
- sudo yum check-update
Review comment:
IMO, `yum check-update` check whether there is a update or not would't bring any benefit for `install_dependencies_with_yum`.
`yum` don't need to update the repo cache after adding a new repo like `apt` does.
Shall we remove it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5385: fix: fix ldap deps in `install-dependencies.sh`
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5385:
URL: https://github.com/apache/apisix/pull/5385#discussion_r740004085
##########
File path: utils/install-dependencies.sh
##########
@@ -24,10 +24,9 @@ function install_dependencies_with_yum() {
# add OpenResty source
sudo yum install yum-utils
sudo yum-config-manager --add-repo "https://openresty.org/package/${1}/openresty.repo"
- sudo yum check-update
Review comment:
`sudo yum check-update || true` would be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org