You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/05/30 13:07:42 UTC

[commons-beanutils] branch master updated (450e66c -> ec5fd5f)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git.


    from 450e66c  Add openjdk14 to Travis.
     new 7a9d793  No need to initialize to default value.
     new ec5fd5f  Refactor constants.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../apache/commons/beanutils2/BasicDynaBean.java   | 30 ++++++++++++++++------
 1 file changed, 22 insertions(+), 8 deletions(-)


[commons-beanutils] 01/02: No need to initialize to default value.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git

commit 7a9d793864a6b8f7757e38708778931c81976b53
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 30 08:41:44 2020 -0400

    No need to initialize to default value.
---
 src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java b/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
index 9dfa1b8..20c3145 100644
--- a/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
+++ b/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
@@ -57,7 +57,7 @@ public class BasicDynaBean implements DynaBean, Serializable {
      * The {@code DynaClass} "base class" that this DynaBean
      * is associated with.
      */
-    protected DynaClass dynaClass = null;
+    protected DynaClass dynaClass;
 
     /**
      * The set of property values for this DynaBean, keyed by property name.


[commons-beanutils] 02/02: Refactor constants.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git

commit ec5fd5f411e3356201fd1e88d8b8d6b5ea3e0964
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat May 30 09:07:37 2020 -0400

    Refactor constants.
---
 .../apache/commons/beanutils2/BasicDynaBean.java   | 28 ++++++++++++++++------
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java b/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
index 20c3145..bb8c2fe 100644
--- a/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
+++ b/src/main/java/org/apache/commons/beanutils2/BasicDynaBean.java
@@ -38,6 +38,20 @@ import java.util.Map;
 
 public class BasicDynaBean implements DynaBean, Serializable {
 
+    private static final Short SHORT_ZERO = Short.valueOf((short) 0);
+
+    private static final Long LONG_ZERO = Long.valueOf(0);
+
+    private static final Integer INTEGER_ZERO = Integer.valueOf(0);
+
+    private static final Float FLOAT_ZERO = Float.valueOf((float) 0.0);
+
+    private static final Double DOUBLE_ZERO = Double.valueOf(0.0);
+
+    private static final Character CHARACTER_ZERO = Character.valueOf((char) 0);
+
+    private static final Byte BYTE_ZERO = Byte.valueOf((byte) 0);
+
     private static final long serialVersionUID = 1L;
 
     /**
@@ -144,19 +158,19 @@ public class BasicDynaBean implements DynaBean, Serializable {
         if (type == Boolean.TYPE) {
             return Boolean.FALSE;
         } else if (type == Byte.TYPE) {
-            return Byte.valueOf((byte) 0);
+            return BYTE_ZERO;
         } else if (type == Character.TYPE) {
-            return Character.valueOf((char) 0);
+            return CHARACTER_ZERO;
         } else if (type == Double.TYPE) {
-            return Double.valueOf(0.0);
+            return DOUBLE_ZERO;
         } else if (type == Float.TYPE) {
-            return Float.valueOf((float) 0.0);
+            return FLOAT_ZERO;
         } else if (type == Integer.TYPE) {
-            return Integer.valueOf(0);
+            return INTEGER_ZERO;
         } else if (type == Long.TYPE) {
-            return Long.valueOf(0);
+            return LONG_ZERO;
         } else if (type == Short.TYPE) {
-            return Short.valueOf((short) 0);
+            return SHORT_ZERO;
         } else {
             return null;
         }