You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by hu...@apache.org on 2020/04/10 04:13:14 UTC

[hbase] branch master updated: HBASE-24161 [flakey test] locking.TestEntityLocks.testEntityLockTimeout (#1477)

This is an automated email from the ASF dual-hosted git repository.

huaxiangsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new ac4e94e  HBASE-24161 [flakey test] locking.TestEntityLocks.testEntityLockTimeout (#1477)
ac4e94e is described below

commit ac4e94e868df5c421908d45d3f9ead1618fdace1
Author: huaxiangsun <hu...@apache.org>
AuthorDate: Thu Apr 9 21:13:06 2020 -0700

    HBASE-24161 [flakey test] locking.TestEntityLocks.testEntityLockTimeout (#1477)
    
    Signed-off-by: stack <st...@apache.org>
---
 .../java/org/apache/hadoop/hbase/client/locking/TestEntityLocks.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/locking/TestEntityLocks.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/locking/TestEntityLocks.java
index 39e70ad..5a2a893 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/locking/TestEntityLocks.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/locking/TestEntityLocks.java
@@ -175,7 +175,10 @@ public class TestEntityLocks {
     assertTrue(lock.isLocked());
     // Should get unlocked in next heartbeat i.e. after workerSleepTime. Wait 10x time to be sure.
     assertTrue(waitLockTimeOut(lock, 10 * workerSleepTime));
-    assertFalse(lock.getWorker().isAlive());
+
+    // Works' run() returns, there is a small gap that the thread is still alive(os
+    // has not declare it is dead yet), so remove the following assertion.
+    // assertFalse(lock.getWorker().isAlive());
     verify(abortable, times(1)).abort(any(), eq(null));
   }