You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/14 03:38:20 UTC

[GitHub] [camel-k] halmakidon opened a new pull request, #3546: Feat(trait): Knative service visibility support

halmakidon opened a new pull request, #3546:
URL: https://github.com/apache/camel-k/pull/3546

   I'd like take up this issue.(#1712) 
   I also need this feature.
   I'm not familiar with the manners, so please let me know if I am wrong.
   
   **Modifications**
   
   * Add visibilitys option
     https://knative.dev/docs/serving/services/private-services/
   
   **Release Note**
   ```release-note
   Feat(trait): Knative service visibility support
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] halmakidon commented on pull request #3546: Feat(trait): Knative service visibility support

Posted by GitBox <gi...@apache.org>.
halmakidon commented on PR #3546:
URL: https://github.com/apache/camel-k/pull/3546#issuecomment-1218862650

   @tadayosi 
   Thank you for your reply.
   I'll leave the rest to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] halmakidon commented on pull request #3546: Feat(trait): Knative service visibility support

Posted by GitBox <gi...@apache.org>.
halmakidon commented on PR #3546:
URL: https://github.com/apache/camel-k/pull/3546#issuecomment-1217553915

   @christophd 
   Thank you for your review.
   Is there anything further I should do after this for the merge?
   (I do not have permission to do the merge)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] tadayosi merged pull request #3546: Feat(trait): Knative service visibility support

Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3546:
URL: https://github.com/apache/camel-k/pull/3546


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] christophd commented on pull request #3546: Feat(trait): Knative service visibility support

Posted by GitBox <gi...@apache.org>.
christophd commented on PR #3546:
URL: https://github.com/apache/camel-k/pull/3546#issuecomment-1217714222

   @halmakidon Unfortunately I also do not have merge permissions
   
   Adding @tadayosi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org