You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/17 12:53:22 UTC
[GitHub] [lucene] jpountz opened a new pull request, #896: LUCENE-9409: Reenable TestAllFilesDetectTruncation.
jpountz opened a new pull request, #896:
URL: https://github.com/apache/lucene/pull/896
- Removed dependency on LineFileDocs to improve reproducibility.
- Relaxed the expected exception type: any exception is ok.
- Ignore rare cases when a file still appears to have a well-formed footer
after truncation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #896: LUCENE-9409: Reenable TestAllFilesDetectTruncation.
Posted by GitBox <gi...@apache.org>.
jpountz merged PR #896:
URL: https://github.com/apache/lucene/pull/896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #896: LUCENE-9409: Reenable TestAllFilesDetectTruncation.
Posted by GitBox <gi...@apache.org>.
jpountz commented on PR #896:
URL: https://github.com/apache/lucene/pull/896#issuecomment-1128913704
The test would still pass without the new checks (another check would fail later), but I thought it was more consistent if we call `checkFooter` for every `IndexInput` we open across all file formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org