[GitHub] [hive] pvary commented on a change in pull request #1735: HIVE-24474: Failed compaction always logs TxnAbortedException (again)

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #1735:
URL: https://github.com/apache/hive/pull/1735#discussion_r536020769



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -561,12 +561,12 @@ protected Boolean findNextCompactionAndExecute(boolean computeStats) throws Inte
       } catch (Throwable e) {
         LOG.error("Caught exception while trying to compact " + ci +
             ".  Marking failed to avoid repeated failures", e);
-        abortCompactionAndMarkFailed(ci, compactorTxnId, e);
+        compactorTxnId = abortCompactionAndMarkFailed(ci, compactorTxnId, e);
       }
     } catch (TException | IOException t) {
       LOG.error("Caught an exception in the main loop of compactor worker " + workerName, t);
       try {
-        abortCompactionAndMarkFailed(ci, compactorTxnId, t);
+        compactorTxnId = abortCompactionAndMarkFailed(ci, compactorTxnId, t);

Review comment:
       Why not just set it to TXN_ID_NOT_SET after calling abortComapctionAndMarkFailed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org