You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/07/07 12:35:22 UTC

[GitHub] [avro] martin-g opened a new pull request #1286: AVRO-3175 Rust: fix lint/clippy errors

martin-g opened a new pull request #1286:
URL: https://github.com/apache/avro/pull/1286


   Fix all linting/clippy errors & warnings.
   Add `build.sh` for Rust that currently supports clean, dist, lint and test targets
   
   ### Jira
   
     - https://issues.apache.org/jira/browse/AVRO-3175
   ### Tests
   
    Tests' source code has been updated to fix linting/clippy errors and warnings
   
   ### Commits
   
   ### Documentation
   
   No public facing API has been modified. No need of documentation changes!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] iemejia merged pull request #1286: AVRO-3175 Rust: fix lint/clippy errors

Posted by GitBox <gi...@apache.org>.
iemejia merged pull request #1286:
URL: https://github.com/apache/avro/pull/1286


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1286: AVRO-3175 Rust: fix lint/clippy errors

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1286:
URL: https://github.com/apache/avro/pull/1286#issuecomment-889119889


   No need to apologies, @iemejia !
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1286: AVRO-3175 Rust: fix lint/clippy errors

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1286:
URL: https://github.com/apache/avro/pull/1286#issuecomment-886694465


   Any feedback on the proposed changes ?
   //CC @iemejia 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] iemejia commented on pull request #1286: AVRO-3175 Rust: fix lint/clippy errors

Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1286:
URL: https://github.com/apache/avro/pull/1286#issuecomment-894624355


   Arghh sorry these have been quite busy days and I somehow missed the notification. Review/Work pace should be back to normal now. Thanks for this one @martin-g 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] martin-g commented on pull request #1286: AVRO-3175 Rust: fix lint/clippy errors

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1286:
URL: https://github.com/apache/avro/pull/1286#issuecomment-876214497


   Cool! GitHub Actions now work too!
   Only the Security Audit does not work because it looks for Cargo.toml only in the root folder. There is an open issue: https://github.com/actions-rs/audit-check/issues/116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] iemejia commented on pull request #1286: AVRO-3175 Rust: fix lint/clippy errors

Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1286:
URL: https://github.com/apache/avro/pull/1286#issuecomment-888945901


   My biggest excuses @martin-g I had checked at this PR like 3 weeks ago and I thought I had approved/merged it, and then I went on holidays. It LGTM I just want to do a tiny ping to @flavray in case he might have some extra comment before merging it.
   
   Thanks (and sorry for the delay, lots of things ongoing these last weeks for me).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org