You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hivemall.apache.org by myui <gi...@git.apache.org> on 2017/07/11 06:34:11 UTC

[GitHub] incubator-hivemall pull request #87: [HIVEMALL-108] Support `-iter` option i...

Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/87#discussion_r126605795
  
    --- Diff: core/src/main/java/hivemall/GeneralLearnerBaseUDTF.java ---
    @@ -220,6 +235,23 @@ protected PrimitiveObjectInspector processFeaturesOI(@Nonnull ObjectInspector ar
             this.featureListOI = (ListObjectInspector) arg;
             ObjectInspector featureRawOI = featureListOI.getListElementObjectInspector();
             HiveUtils.validateFeatureOI(featureRawOI);
    +        if (featureRawOI instanceof JavaStringObjectInspector) {
    --- End diff --
    
    We need to consider other possibilities for StringObjectInspector.
    https://gyazo.com/4c7c3efb22f441db09f614457235b5c0
    
    I'll handle this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---