[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4693: Fetch new schema when loading committed real-time segments

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4693: Fetch new schema when loading committed real-time segments
URL: https://github.com/apache/incubator-pinot/pull/4693#discussion_r333770616
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
 ##########
 @@ -205,9 +196,18 @@ public void notifySegmentCommitted(String tableNameWithType, RealtimeSegmentZKMe
   public void addSegment(@Nonnull String segmentName, @Nonnull TableConfig tableConfig,
       @Nonnull IndexLoadingConfig indexLoadingConfig)
       throws Exception {
+    SegmentDataManager segmentDataManager = _segmentDataManagerMap.get(segmentName);
+    if (segmentDataManager != null) {
+      _logger.warn("Skipping adding existing segment: {} for table: {} with data manager class: {}", segmentName,
 
 Review comment:
   you don't need table name or class name  since  _logger already has these in it. Please remove them. Also, please clarify the message in the log. "Skipping because we already found the segment loaded". We should not need to look into  the code to check the reason.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org