You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/27 10:37:08 UTC

[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1303: [KYUUBI #1293] Set the sub.domain default value

yaooqinn commented on a change in pull request #1303:
URL: https://github.com/apache/incubator-kyuubi/pull/1303#discussion_r737334271



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -586,7 +586,7 @@ object KyuubiConf {
       .transform(_.toLowerCase(Locale.ROOT))
       .checkValue(validEngineSubDomain.matcher(_).matches(),
         "must be [1, 10] length alphabet string, e.g. 'abc', 'apache'")
-      .createOptional
+      .createWithDefaultString("default")

Review comment:
       nit: we use createWithDefault




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org