You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Raghav Gautam <ra...@gmail.com> on 2014/08/05 01:59:58 UTC
Review Request 24285: fixing checkstyle issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24285/
-----------------------------------------------------------

Review request for Falcon.


Bugs: FALCON-563
    https://issues.apache.org/jira/browse/FALCON-563


Repository: falcon-git


Description
-------

Falcon regression code that was recently merged has check style issues. This patch fixes them.


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 182f36e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java 11d3fb0 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java b9db07e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 84ecb9c 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/RetentionUnit.java d1ece18 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ClusterEntityHelperImpl.java 129ea62 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ColoHelper.java 05b4f73 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/DataEntityHelperImpl.java 7800c50 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/helpers/ProcessEntityHelperImpl.java c037b5e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/EntityHelperFactory.java ffda6e5 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 01eb02f 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/APIResult.java 40d640a 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntitiesResult.java 5a77680 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/EntityResult.java f44c340 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/InstancesResult.java 8d1311b 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ResponseKeys.java a9ea122 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/ServiceResponse.java 259e6e4 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Direction.java 6d3665f 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java 66e6664 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgeResult.java 420d88f 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java 6b15cfa 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphEntity.java 2bef659 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/GraphResult.java ac8ed77 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/NODE_TYPE.java c315bd4 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java d2690ae 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/VertexIdsResult.java 8f77b5e 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/VertexResult.java 01954f0 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/VerticesResult.java a35cd2d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/Brother.java 77a5cc6 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/HadoopFileEditor.java 0ebcb53 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/JmsMessageConsumer.java d7e952b 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java db73eda 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Config.java a6e83ef 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Generator.java 86f9d6f 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/BaseRequest.java 8d125b0 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/request/RequestKeys.java b2a02f7 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/security/FalconAuthorizationToken.java 3c26567 

Diff: https://reviews.apache.org/r/24285/diff/


Testing
-------

Ran EmbeddedPigScriptTest, LineageApiTest, LineageApiTest, RetentionTest#testRetentionWithEmptyDirectories


Thanks,

Raghav Gautam