You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/04 06:20:57 UTC

[GitHub] [spark] panbingkun commented on pull request #37058: [SPARK-39661][CORE][SHUFFLE][SQL] Avoid creating unnecessary SLF4J Logger

panbingkun commented on PR #37058:
URL: https://github.com/apache/spark/pull/37058#issuecomment-1173398873

   > Change from instance to static variable makes sense. You can revert changes to `NettyBlockTransferService`.
   Reason：Because nettyblocktransferservice is a singleton in every executor ？
   Ok，i will revert nettyblocktransferservice.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org