You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/09/03 17:53:29 UTC

[GitHub] [tinkerpop] spmallette opened a new pull request #1471: TINKERPOP-2605 Improve null handling in a variety of steps

spmallette opened a new pull request #1471:
URL: https://github.com/apache/tinkerpop/pull/1471


   https://issues.apache.org/jira/browse/TINKERPOP-2605
   
   The JIRA outlines the steps that fail when `null` is encountered in some way. There are still further cases where things aren't working properly but this PR is getting large enough. It may be sufficient to review this PR just be looking at the gherkin tests that establish the semantics, but feel free to dig into the code if desired. Here' a sample of things working now that weren't before:
   
   ```text
   gremlin> g.V().hasLabel(null)
   gremlin> g.V().has('name',within('josh',null))
   ==>v[4]
   gremlin> g.V().has('name',within(null))
   gremlin> g.V().values('age').inject(null).sum()
   ==>123
   gremlin> g.inject(null,null,null).sum()
   ==>null
   gremlin> g.V().values('age').inject(null).min()
   ==>27
   gremlin> g.V().values('age').inject(null).max()
   ==>35
   gremlin> g.inject(null,null,null).min()
   ==>null
   gremlin> g.inject(null,null,null).max()
   ==>null
   gremlin> g.V().values('age').inject(null).mean()
   ==>30.75
   gremlin> g.inject(null,null,null).mean()
   ==>null
   gremlin> g.V().properties().hasKey(null)
   gremlin> g.V().properties().hasValue(null)
   gremlin> g.withSideEffect('k',null).inject(1).select('k')
   ==>null
   gremlin> g.inject(null,1).as('a').path()
   ==>[null]
   ==>[1]
   ```
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tinkerpop] spmallette merged pull request #1471: TINKERPOP-2605 Improve null handling in a variety of steps

Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1471:
URL: https://github.com/apache/tinkerpop/pull/1471


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tinkerpop] bechbd commented on pull request #1471: TINKERPOP-2605 Improve null handling in a variety of steps

Posted by GitBox <gi...@apache.org>.
bechbd commented on pull request #1471:
URL: https://github.com/apache/tinkerpop/pull/1471#issuecomment-914570058


   I tried out the changes and they all are working as I would expect
   
   VOTE +1
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org