You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/11 07:41:51 UTC

[GitHub] [pulsar] saosir opened a new pull request #9170: [C++] UnAckedMessageTracker handles batch message incorrectly

saosir opened a new pull request #9170:
URL: https://github.com/apache/pulsar/pull/9170


   ### Motivation
   
    It is necessary to reset  batchIndex of MessageId when tracking a message. Because only the ack of the last message in batch  is 
    removed from `UnAckedMessageTrackerEnabled`
   
   ### Modifications
   
   when track or untrack a message, reset batchIndex of MessageId to -1
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #9170: [C++] UnAckedMessageTracker handles batch message incorrectly

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9170:
URL: https://github.com/apache/pulsar/pull/9170


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #9170: [C++] UnAckedMessageTracker handles batch message incorrectly

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9170:
URL: https://github.com/apache/pulsar/pull/9170#issuecomment-758003745


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] jiazhai commented on pull request #9170: [C++] UnAckedMessageTracker handles batch message incorrectly

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9170:
URL: https://github.com/apache/pulsar/pull/9170#issuecomment-758006032


   @BewareMyPower  Would you please also take a look of this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] saosir commented on pull request #9170: [C++] UnAckedMessageTracker handles batch message incorrectly

Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9170:
URL: https://github.com/apache/pulsar/pull/9170#issuecomment-757858879


   /pulsarbot run-failure-checks
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] saosir commented on pull request #9170: [C++] UnAckedMessageTracker handles batch message incorrectly

Posted by GitBox <gi...@apache.org>.
saosir commented on pull request #9170:
URL: https://github.com/apache/pulsar/pull/9170#issuecomment-757680822


   see https://github.com/apache/pulsar/pull/9072#issuecomment-751923349


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org