You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/09/13 10:19:41 UTC
[GitHub] [carbondata] ravipesala commented on a change in pull request
#3381: [CARBONDATA-3517]Add Segment with Path
ravipesala commented on a change in pull request #3381: [CARBONDATA-3517]Add Segment with Path
URL: https://github.com/apache/carbondata/pull/3381#discussion_r324128385
##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
##########
@@ -133,8 +133,11 @@
// structure
byte[] filePath = null;
boolean isPartitionTable = blockletDataMapInfo.getCarbonTable().isHivePartitionTable();
- if (isPartitionTable || !blockletDataMapInfo.getCarbonTable().isTransactionalTable()
- || blockletDataMapInfo.getCarbonTable().isSupportFlatFolder()) {
+ if (isPartitionTable || !blockletDataMapInfo.getCarbonTable().isTransactionalTable() ||
+ blockletDataMapInfo.getCarbonTable().isSupportFlatFolder() ||
+ // if the segment data is written in tablepath then no need to store whole path of file.
+ !blockletDataMapInfo.getFilePath().startsWith(
+ blockletDataMapInfo.getCarbonTable().getTablePath())) {
filePath = path.getParent().toString().getBytes(CarbonCommonConstants.DEFAULT_CHARSET);
Review comment:
Ok, Handled and added test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services