You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/08/05 20:46:54 UTC
Review Request 24331: Add filter to resourcesRecovered.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-1672
https://issues.apache.org/jira/browse/MESOS-1672
Repository: mesos-git
Description
-------
add a filter to resourcesRecovered to avoid a tight loop between master and allocator.
Diffs
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 77f2536c36df9a0a1f6021bd4732baa3ab424459
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 0b17a8afb6aa66ab19f6fcd90906fb4eb2c39f05
Diff: https://reviews.apache.org/r/24331/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49774
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 6, 2014, 5:31 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 5:31 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49776
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 6, 2014, 5:31 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 5:31 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 10:31 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-1672
https://issues.apache.org/jira/browse/MESOS-1672
Repository: mesos-git
Description
-------
merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
Diffs (updated)
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
Diff: https://reviews.apache.org/r/24331/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Aug. 6, 2014, 10:18 a.m., Jie Yu wrote:
> > src/master/hierarchical_allocator_process.hpp, lines 601-607
> > <https://reviews.apache.org/r/24331/diff/3/?file=653875#file653875line601>
> >
> > What if 'frameworks' does not contain 'frameworkId'? What if !slaves.contains(slaveId)?
nice catch!
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49751
-----------------------------------------------------------
On Aug. 6, 2014, 10:17 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 10:17 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49751
-----------------------------------------------------------
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/24331/#comment87060>
What if 'frameworks' does not contain 'frameworkId'? What if !slaves.contains(slaveId)?
- Jie Yu
On Aug. 6, 2014, 5:17 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 5:17 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 10:17 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-1672
https://issues.apache.org/jira/browse/MESOS-1672
Repository: mesos-git
Description
-------
merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
Diffs (updated)
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
Diff: https://reviews.apache.org/r/24331/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Aug. 6, 2014, 10:02 a.m., Jie Yu wrote:
> > src/master/hierarchical_allocator_process.hpp, lines 568-571
> > <https://reviews.apache.org/r/24331/diff/3/?file=653875#file653875line568>
> >
> > Will this increase the logging a lot? Every time the framework launch tasks with unused resources, we'll see this log line.
> >
> > Seems that this is not the case in the previous version. Do we need LOG(INFO) here, or we can just use VLOG(1) here?
i was worried about losing the logging that we had in the 'recovered' case here. Perhaps a VLOG(1) is ok.. but is logging really that big a deal?
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49747
-----------------------------------------------------------
On Aug. 6, 2014, 9:41 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 9:41 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 6, 2014, 5:02 p.m., Jie Yu wrote:
> > src/master/hierarchical_allocator_process.hpp, lines 568-571
> > <https://reviews.apache.org/r/24331/diff/3/?file=653875#file653875line568>
> >
> > Will this increase the logging a lot? Every time the framework launch tasks with unused resources, we'll see this log line.
> >
> > Seems that this is not the case in the previous version. Do we need LOG(INFO) here, or we can just use VLOG(1) here?
>
> Dominic Hamon wrote:
> i was worried about losing the logging that we had in the 'recovered' case here. Perhaps a VLOG(1) is ok.. but is logging really that big a deal?
there was already a log line "framework filtered slave..." whenever resourcesUnused() was called, so this doesn't seem bad to me. infact i prefer to keep the LOG(INFO) for "recovered resources.." and change the "framework filtered..." log line to VLOG because the latter is really not that useful except for debugging.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49747
-----------------------------------------------------------
On Aug. 6, 2014, 4:41 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 4:41 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 6, 2014, 5:02 p.m., Jie Yu wrote:
> > src/master/hierarchical_allocator_process.hpp, lines 568-571
> > <https://reviews.apache.org/r/24331/diff/3/?file=653875#file653875line568>
> >
> > Will this increase the logging a lot? Every time the framework launch tasks with unused resources, we'll see this log line.
> >
> > Seems that this is not the case in the previous version. Do we need LOG(INFO) here, or we can just use VLOG(1) here?
>
> Dominic Hamon wrote:
> i was worried about losing the logging that we had in the 'recovered' case here. Perhaps a VLOG(1) is ok.. but is logging really that big a deal?
>
> Vinod Kone wrote:
> there was already a log line "framework filtered slave..." whenever resourcesUnused() was called, so this doesn't seem bad to me. infact i prefer to keep the LOG(INFO) for "recovered resources.." and change the "framework filtered..." log line to VLOG because the latter is really not that useful except for debugging.
Hum... Can we merge these two log lines? Something like:
LOG(INFO) << "Recovered ..." << "(" << (filters.isSome() ? filters.get().refuse_seconds() : "no filter") << ")";
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49747
-----------------------------------------------------------
On Aug. 6, 2014, 5:17 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 5:17 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49747
-----------------------------------------------------------
Ship it!
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/24331/#comment87055>
Will this increase the logging a lot? Every time the framework launch tasks with unused resources, we'll see this log line.
Seems that this is not the case in the previous version. Do we need LOG(INFO) here, or we can just use VLOG(1) here?
- Jie Yu
On Aug. 6, 2014, 4:41 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 4:41 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 9:41 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-1672
https://issues.apache.org/jira/browse/MESOS-1672
Repository: mesos-git
Description
-------
merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
Diffs (updated)
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
Diff: https://reviews.apache.org/r/24331/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/#review49679
-----------------------------------------------------------
Ship it!
src/master/hierarchical_allocator_process.hpp
<https://reviews.apache.org/r/24331/#comment86959>
why the change in formatting? the previous one looks fine to me.
- Vinod Kone
On Aug. 5, 2014, 10:50 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24331/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 10:50 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1672
> https://issues.apache.org/jira/browse/MESOS-1672
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
>
>
> Diffs
> -----
>
> docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
> docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
> src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
> src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
> src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
> src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
>
> Diff: https://reviews.apache.org/r/24331/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 3:50 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
add vinodkone.
Bugs: MESOS-1672
https://issues.apache.org/jira/browse/MESOS-1672
Repository: mesos-git
Description
-------
merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
Diffs
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
Diff: https://reviews.apache.org/r/24331/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 24331: Merge resourcesRecovered and resourcesUnused.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24331/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 3:50 p.m.)
Review request for mesos and Jie Yu.
Summary (updated)
-----------------
Merge resourcesRecovered and resourcesUnused.
Bugs: MESOS-1672
https://issues.apache.org/jira/browse/MESOS-1672
Repository: mesos-git
Description (updated)
-------
merge resourcesRecovered and resourcesUnused and update callsites/tests accordingly.
Diffs (updated)
-----
docs/allocation-module.md b308a23c0cdaf9bcb31fc0b13f584cd04cfa1aaa
docs/mesos-c++-style-guide.md 35a49c73960cb35eed49418def24bccc8a76ebc1
src/master/allocator.hpp be6b038a9db076fb26cf40bfb61181f0fa860938
src/master/hierarchical_allocator_process.hpp 35d1579bbd665dfdd238932902ae16880dadeb66
src/master/master.cpp 9bede96083f56768a5d42baf051af97de4c48d48
src/tests/allocator_tests.cpp b920533bbc36a154c02b467673bc7a0d50d65bc7
src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/slave_recovery_tests.cpp 8d48aedc0754de192210841ef9234531e179f6fb
Diff: https://reviews.apache.org/r/24331/diff/
Testing
-------
make check
Thanks,
Dominic Hamon