You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/10/13 18:03:40 UTC
[PR] HDDS-11574. Ozone client leak in TestS3SDKV1 [ozone]
adoroszlai opened a new pull request, #7308:
URL: https://github.com/apache/ozone/pull/7308
## What changes were proposed in this pull request?
- Fix `OzoneClient` leak in S3G integration test:
https://github.com/apache/ozone/actions/runs/11315912516/attempts/1#summary-31467801190
- `HddsUtils#reportLeak` is supposed to print the leak's stack trace if log level is at least `DEBUG`. However, it checks the wrong `Logger` instance: `HddsUtils`'s `LOG` instead of the argument `log`. This method was moved from `ManagedRocksObjectUtils` by HDDS-11543, adding the new parameter, but keeping the `LOG.isDebugEnabled()` check.
- Set `OzoneClientFactory` log level to `DEBUG` in integration tests to get stack trace of `OzoneClient` leaks.
https://issues.apache.org/jira/browse/HDDS-11574
## How was this patch tested?
```
$ mvn -am -pl :ozone-integration-test -Dtest='TestS3SDKV1*' clean test
$ grep 'not closed properly' hadoop-ozone/integration-test/target/surefire-reports/*TestS3SDKV1*-output.txt | wc -l
0
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/11316491577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11574. Ozone client leak in TestS3SDKV1 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7308:
URL: https://github.com/apache/ozone/pull/7308#issuecomment-2409871216
Thanks @ivandika3 for reviewing and merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11574. Ozone client leak in TestS3SDKV1 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #7308:
URL: https://github.com/apache/ozone/pull/7308#issuecomment-2409688514
Thanks @adoroszlai for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11574. Ozone client leak in TestS3SDKV1 [ozone]
Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #7308:
URL: https://github.com/apache/ozone/pull/7308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org