You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/12 07:43:07 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request #2: [FLINK-25625] Introduce FileFormat
JingsongLi opened a new pull request #2:
URL: https://github.com/apache/flink-table-store/pull/2
Introduce file format class which creates reader and writer factories for specific file format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #2: [FLINK-25625] Introduce FileFormat
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #2:
URL: https://github.com/apache/flink-table-store/pull/2#discussion_r782782354
##########
File path: pom.xml
##########
@@ -153,12 +154,6 @@ under the License.
<version>1.3.9</version>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-shaded-jackson</artifactId>
Review comment:
Useless depedency.
##########
File path: pom.xml
##########
@@ -153,12 +154,6 @@ under the License.
<version>1.3.9</version>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-shaded-jackson</artifactId>
Review comment:
Useless dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #2: [FLINK-25625] Introduce FileFormat
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #2:
URL: https://github.com/apache/flink-table-store/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #2: [FLINK-25625] Introduce FileFormat
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #2:
URL: https://github.com/apache/flink-table-store/pull/2#discussion_r782782673
##########
File path: pom.xml
##########
@@ -444,7 +439,7 @@ under the License.
<rules>
<bannedDependencies>
<excludes>
- <exclude>com.fasterxml.jackson*:*:(,2.12.0]</exclude>
Review comment:
flink-avro uses jackson 2.11 (from avro)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org