You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/06/18 16:38:37 UTC

[GitHub] [tinkerpop] spmallette opened a new pull request #1146: TINKERPOP-2248 Force replacement of connections on certain errors

spmallette opened a new pull request #1146: TINKERPOP-2248 Force replacement of connections on certain errors
URL: https://github.com/apache/tinkerpop/pull/1146
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2248
   
   Relying only on the `Connection.isDead()` check to determine connection replacement seemed to introduce a regression as of 2cd84ff1f3944d67d44cbba5bb032a1c57377975 The `shouldBlockRequestWhenTooBig` was failing somewhat randomly since that change. Not sure if there is a better way to make `isDead()` be the only check needed for connection replacement in this context, but this change brings the logic back that checks exception types that were forcing replacement prior to this change. 
   
   @divijvaidya would you mind having a look at this change? perhaps you are aware of better solutions or perhaps I misinterpreted something in my analysis that you could correct?
   
   All tests pass with `docker/build.sh -t -i`
   
   VOTE +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services