[GitHub] [iceberg] nastra commented on a diff in pull request #7719: Spark 3.1: Fixes bucket on binary column

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7719:
URL: https://github.com/apache/iceberg/pull/7719#discussion_r1213164194


##########
spark/v3.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestIcebergExpressions.java:
##########
@@ -71,4 +72,34 @@ public void testTruncateExpressions() {
         ImmutableList.of(row(100, 10000L, new BigDecimal("10.50"), "10", "12")),
         sql("SELECT int_c, long_c, dec_c, str_c, CAST(binary_c AS STRING) FROM v"));
   }
+
+  @Test
+  public void testBucketExpressions() {

Review Comment:
   can we add `testDefaultSortOnBinaryBucketedColumn` to some other test file maybe?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org