You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/05/13 23:54:52 UTC
Review Request 47375: GEODE-1393 locator returns incorrect server
information when starting up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47375/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
Repository: geode
Description
-------
When a locator auto-reconnects its ServerLocator needs to initialize its ControllerAdvisor so that it has server information to give to clients. The ServerLocator was creating a new ControllerAdvisor but didn't ask it to perform a handshake to fill in its profiles.
I've kept some of the changes to ServerLocator and LocatorStats from the last go-round. The primary change in ServerAdvisor for this ticket is in restarting() and there is a comment for this ticket.
ReconnectDUnitTest had an existing testReconnectWithQuorum test that wasn't doing what it was supposed to. I've removed the TODO from that test and modified it to force-disconnect the tests Locator. The locator must restart its TcpServer component before it can start a DistributedSystem, so this exercises the path in InternalLocator.attemptReconnect() that boots the TcpServer prior to connecting the DistributedSystem. After the DistributedSystem finishes reconnecting the ServerLocator's distribution advisor should have been initialized by performing the handshake.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java d42a2b45a4383931318e97bf0575e084ef4aa7ed
geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java e535b97688e74ce30b259cbe78c9921db9ba9c13
geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java ca2c17be036cb2f86d0dcf7f59cca028d1cb212f
Diff: https://reviews.apache.org/r/47375/diff/
Testing
-------
precheckin is running
Thanks,
Bruce Schuchardt
Re: Review Request 47375: GEODE-1393 locator returns incorrect server
information when starting up
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47375/#review133452
-----------------------------------------------------------
Ship it!
Ship It!
- Jianxia Chen
On May 13, 2016, 11:54 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47375/
> -----------------------------------------------------------
>
> (Updated May 13, 2016, 11:54 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When a locator auto-reconnects its ServerLocator needs to initialize its ControllerAdvisor so that it has server information to give to clients. The ServerLocator was creating a new ControllerAdvisor but didn't ask it to perform a handshake to fill in its profiles.
>
> I've kept some of the changes to ServerLocator and LocatorStats from the last go-round. The primary change in ServerAdvisor for this ticket is in restarting() and there is a comment for this ticket.
>
> ReconnectDUnitTest had an existing testReconnectWithQuorum test that wasn't doing what it was supposed to. I've removed the TODO from that test and modified it to force-disconnect the tests Locator. The locator must restart its TcpServer component before it can start a DistributedSystem, so this exercises the path in InternalLocator.attemptReconnect() that boots the TcpServer prior to connecting the DistributedSystem. After the DistributedSystem finishes reconnecting the ServerLocator's distribution advisor should have been initialized by performing the handshake.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java d42a2b45a4383931318e97bf0575e084ef4aa7ed
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java e535b97688e74ce30b259cbe78c9921db9ba9c13
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java ca2c17be036cb2f86d0dcf7f59cca028d1cb212f
>
> Diff: https://reviews.apache.org/r/47375/diff/
>
>
> Testing
> -------
>
> precheckin is running
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 47375: GEODE-1393 locator returns incorrect server
information when starting up
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47375/#review133233
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On May 13, 2016, 11:54 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47375/
> -----------------------------------------------------------
>
> (Updated May 13, 2016, 11:54 p.m.)
>
>
> Review request for geode, Hitesh Khamesra, Jianxia Chen, Udo Kohlmeyer, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When a locator auto-reconnects its ServerLocator needs to initialize its ControllerAdvisor so that it has server information to give to clients. The ServerLocator was creating a new ControllerAdvisor but didn't ask it to perform a handshake to fill in its profiles.
>
> I've kept some of the changes to ServerLocator and LocatorStats from the last go-round. The primary change in ServerAdvisor for this ticket is in restarting() and there is a comment for this ticket.
>
> ReconnectDUnitTest had an existing testReconnectWithQuorum test that wasn't doing what it was supposed to. I've removed the TODO from that test and modified it to force-disconnect the tests Locator. The locator must restart its TcpServer component before it can start a DistributedSystem, so this exercises the path in InternalLocator.attemptReconnect() that boots the TcpServer prior to connecting the DistributedSystem. After the DistributedSystem finishes reconnecting the ServerLocator's distribution advisor should have been initialized by performing the handshake.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/LocatorStats.java d42a2b45a4383931318e97bf0575e084ef4aa7ed
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/ServerLocator.java e535b97688e74ce30b259cbe78c9921db9ba9c13
> geode-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java ca2c17be036cb2f86d0dcf7f59cca028d1cb212f
>
> Diff: https://reviews.apache.org/r/47375/diff/
>
>
> Testing
> -------
>
> precheckin is running
>
>
> Thanks,
>
> Bruce Schuchardt
>
>